Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files Errors
75 820

Files

Files Errors
org/picocontainer/PicoContainer.java 8
org/picocontainer/PicoException.java 2
org/picocontainer/PicoInitializationException.java 2
org/picocontainer/PicoInstantiationException.java 3
org/picocontainer/PicoIntrospectionException.java 2
org/picocontainer/PicoRegistrationException.java 2
org/picocontainer/RegistrationPicoContainer.java 29
org/picocontainer/defaults/AmbiguousComponentResolutionException.java 15
org/picocontainer/defaults/AssignabilityRegistrationException.java 13
org/picocontainer/defaults/DefaultComponentFactory.java 24
org/picocontainer/defaults/DefaultComponentRegistry.java 88
org/picocontainer/defaults/DefaultCompositeProxyFactory.java 45
org/picocontainer/defaults/DefaultPicoContainer.java 149
org/picocontainer/defaults/DuplicateComponentKeyRegistrationException.java 11
org/picocontainer/defaults/NoPicoSuitableConstructorException.java 9
org/picocontainer/defaults/NotConcreteRegistrationException.java 11
org/picocontainer/defaults/PicoInvocationTargetInitializationException.java 11
org/picocontainer/defaults/UnsatisfiedDependencyInstantiationException.java 19
org/picocontainer/extras/CompositePicoContainer.java 39
org/picocontainer/extras/CompositeProxyFactory.java 2
org/picocontainer/extras/DefaultLifecyclePicoAdaptor.java 31
org/picocontainer/extras/HierarchicalComponentRegistry.java 82
org/picocontainer/extras/ImplementationHidingComponentFactory.java 34
org/picocontainer/extras/NullContainer.java 22
org/picocontainer/internals/ComponentFactory.java 16
org/picocontainer/internals/ComponentParameter.java 26
org/picocontainer/internals/ComponentRegistry.java 25
org/picocontainer/internals/ComponentSpecification.java 69
org/picocontainer/internals/ConstantParameter.java 11
org/picocontainer/internals/Parameter.java 4
org/picocontainer/lifecycle/Disposable.java 3
org/picocontainer/lifecycle/Lifecycle.java 2
org/picocontainer/lifecycle/LifecyclePicoAdaptor.java 5
org/picocontainer/lifecycle/Startable.java 3
org/picocontainer/lifecycle/Stoppable.java 3

org/picocontainer/PicoContainer.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Expected @throws tag for 'PicoInitializationException'. 51
Unable to get class information for PicoInitializationException. 51
Line is longer than 80 characters. 54
Line is longer than 80 characters. 66
Line is longer than 80 characters. 67
Expected an @return tag. 69
Line is longer than 80 characters. 69

org/picocontainer/PicoException.java

Error Line
Missing a header - not enough lines in file. 1
Line has trailing spaces. 6

org/picocontainer/PicoInitializationException.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 13

org/picocontainer/PicoInstantiationException.java

Error Line
Missing a header - not enough lines in file. 1
Line is longer than 80 characters. 13
Missing a Javadoc comment. 13

org/picocontainer/PicoIntrospectionException.java

Error Line
Missing a header - not enough lines in file. 1
Line is longer than 80 characters. 8

org/picocontainer/PicoRegistrationException.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 13

org/picocontainer/RegistrationPicoContainer.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Missing a Javadoc comment. 15
Line is longer than 80 characters. 18
Redundant throws: 'PicoRegistrationException' is subclass of 'PicoIntrospectionException'. 25
Unable to get class information for PicoRegistrationException. 25
Expected @throws tag for 'PicoIntrospectionException'. 25
Unable to get class information for PicoIntrospectionException. 25
Redundant throws: 'PicoRegistrationException' is subclass of 'PicoIntrospectionException'. 36
Unable to get class information for PicoRegistrationException. 36
Expected @throws tag for 'PicoIntrospectionException'. 36
Unable to get class information for PicoIntrospectionException. 36
Redundant throws: 'PicoRegistrationException' is subclass of 'PicoIntrospectionException'. 48
Unable to get class information for PicoRegistrationException. 48
Expected @throws tag for 'PicoIntrospectionException'. 48
Unable to get class information for PicoIntrospectionException. 48
Line is longer than 80 characters. 52
Line is longer than 80 characters. 53
Expected @throws tag for 'PicoRegistrationException'. 59
Redundant throws: 'PicoRegistrationException' is subclass of 'PicoIntrospectionException'. 59
Unable to get class information for PicoRegistrationException. 59
Expected @throws tag for 'PicoIntrospectionException'. 59
Unable to get class information for PicoIntrospectionException. 59
Line is longer than 80 characters. 62
Line is longer than 80 characters. 68
Expected @param tag for 'parameters'. 68
Unable to get class information for PicoRegistrationException. 69
Line is longer than 80 characters. 78
Expected @throws tag for 'PicoIntrospectionException'. 78
Unable to get class information for PicoIntrospectionException. 78

org/picocontainer/defaults/AmbiguousComponentResolutionException.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Line is longer than 80 characters. 16
Missing a Javadoc comment. 16
Missing a Javadoc comment. 17
Missing a Javadoc comment. 18
Line is longer than 80 characters. 20
Missing a Javadoc comment. 20
Parameter ambiguousClass should be final. 20
'ambiguousClass' hides a field. 20
Parameter foundKeys should be final. 20
'foundKeys' hides a field. 20
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. 25
Missing a Javadoc comment. 25
Method 'getResultingKeys' is not designed for extension - needs to be abstract, final or empty. 35
Missing a Javadoc comment. 35

org/picocontainer/defaults/AssignabilityRegistrationException.java

Error Line
Missing a header - not enough lines in file. 1
Line is longer than 80 characters. 15
Missing a Javadoc comment. 15
Missing a Javadoc comment. 16
Missing a Javadoc comment. 17
Missing a Javadoc comment. 19
Parameter type should be final. 19
'type' hides a field. 19
Parameter clazz should be final. 19
'clazz' hides a field. 19
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. 24
Missing a Javadoc comment. 24
Line is longer than 80 characters. 25

org/picocontainer/defaults/DefaultComponentFactory.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Line is longer than 80 characters. 28
Method 'createComponent' is not designed for extension - needs to be abstract, final or empty. 28
Missing a Javadoc comment. 28
Parameter componentSpec should be final. 28
Parameter instanceDependencies should be final. 28
Redundant throws: 'PicoInvocationTargetInitializationException' is subclass of 'NoPicoSuitableConstructorException'. 28
Unable to get class information for PicoInvocationTargetInitializationException. 28
Unable to get class information for NoPicoSuitableConstructorException. 28
Line is longer than 80 characters. 30
Line is longer than 80 characters. 41
Method 'getDependencies' is not designed for extension - needs to be abstract, final or empty. 41
Missing a Javadoc comment. 41
Parameter componentImplementation should be final. 41
Unable to get class information for PicoIntrospectionException. 41
Expected an @return tag. 52
Line is longer than 80 characters. 52
Parameter componentImplementation should be final. 52
Expected @param tag for 'componentImplementation'. 52
Expected @throws tag for 'NoPicoSuitableConstructorException'. 52
Unable to get class information for NoPicoSuitableConstructorException. 52
Line is longer than 80 characters. 57
Line is longer than 80 characters. 59
Line is longer than 80 characters. 65

org/picocontainer/defaults/DefaultComponentRegistry.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Unused import - org.picocontainer.PicoContainer. 14
Using the '.*' form of import should be avoided - java.util.*. 18
Line is longer than 80 characters. 27
Missing a Javadoc comment. 29
Variable 'registeredComponentSpecifications' must be private and have accessor methods. 29
Missing a Javadoc comment. 32
Variable 'orderedComponents' must be private and have accessor methods. 32
Missing a Javadoc comment. 34
Variable 'componentKeyToInstanceMap' must be private and have accessor methods. 34
Missing a Javadoc comment. 36
Variable 'componentToSpec' must be private and have accessor methods. 36
Missing a Javadoc comment. 39
Method 'registerComponent' is not designed for extension - needs to be abstract, final or empty. 46
Missing a Javadoc comment. 46
Parameter compSpec should be final. 46
Line has trailing spaces. 50
Line contains a tab character. 51
Method 'unregisterComponent' is not designed for extension - needs to be abstract, final or empty. 51
Missing a Javadoc comment. 51
Parameter componentKey should be final. 51
Line is longer than 80 characters. 52
Line contains a tab character. 52
Line is longer than 80 characters. 53
Line contains a tab character. 53
Line has trailing spaces. 54
Line contains a tab character. 54
Line is longer than 80 characters. 55
Line contains a tab character. 55
Line is longer than 80 characters. 56
Line contains a tab character. 56
Line contains a tab character. 58
Line contains a tab character. 59
Line contains a tab character. 60
Line contains a tab character. 61
Method 'getComponentSpecifications' is not designed for extension - needs to be abstract, final or empty. 63
Missing a Javadoc comment. 63
Method 'getOrderedComponents' is not designed for extension - needs to be abstract, final or empty. 67
Missing a Javadoc comment. 67
Method 'addOrderedComponent' is not designed for extension - needs to be abstract, final or empty. 71
Missing a Javadoc comment. 71
Parameter component should be final. 71
Method 'putComponent' is not designed for extension - needs to be abstract, final or empty. 75
Missing a Javadoc comment. 75
Parameter componentKey should be final. 75
Parameter component should be final. 75
Method 'contains' is not designed for extension - needs to be abstract, final or empty. 79
Missing a Javadoc comment. 79
Parameter componentKey should be final. 79
Method 'getComponentInstance' is not designed for extension - needs to be abstract, final or empty. 83
Missing a Javadoc comment. 83
Parameter componentKey should be final. 83
Method 'getComponentInstanceKeys' is not designed for extension - needs to be abstract, final or empty. 87
Missing a Javadoc comment. 87
Method 'getComponentInstances' is not designed for extension - needs to be abstract, final or empty. 92
Missing a Javadoc comment. 92
Method 'hasComponentInstance' is not designed for extension - needs to be abstract, final or empty. 104
Missing a Javadoc comment. 104
Parameter componentKey should be final. 104
Method 'getComponentSpec' is not designed for extension - needs to be abstract, final or empty. 108
Missing a Javadoc comment. 108
Parameter componentKey should be final. 108
Line is longer than 80 characters. 112
Method 'findImplementingComponent' is not designed for extension - needs to be abstract, final or empty. 112
Missing a Javadoc comment. 112
Parameter componentType should be final. 112
Unable to get class information for AmbiguousComponentResolutionException. 112
Line is longer than 80 characters. 115
Line is longer than 80 characters. 125
Avoid inline conditionals. 128
Line is longer than 80 characters. 131
Method 'findImplementingComponentSpecification' is not designed for extension - needs to be abstract, final or empty. 131
Missing a Javadoc comment. 131
Parameter componentType should be final. 131
Unable to get class information for AmbiguousComponentResolutionException. 131
Line is longer than 80 characters. 133
Line is longer than 80 characters. 134
Line is longer than 80 characters. 136
Line is longer than 80 characters. 144
Line is longer than 80 characters. 146
Avoid inline conditionals. 149
Line is longer than 80 characters. 153
Method 'createComponent' is not designed for extension - needs to be abstract, final or empty. 153
Missing a Javadoc comment. 153
Parameter componentSpecification should be final. 153
Unable to get class information for PicoInitializationException. 153
Line is longer than 80 characters. 155
Line is longer than 80 characters. 162

org/picocontainer/defaults/DefaultCompositeProxyFactory.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Line is longer than 80 characters. 33
Missing a Javadoc comment. 35
Missing a Javadoc comment. 36
Line is longer than 80 characters. 40
Method 'createCompositeProxy' is not designed for extension - needs to be abstract, final or empty. 53
Missing a Javadoc comment. 53
Parameter classLoader should be final. 54
Parameter objectsToAggregateCallFor should be final. 55
Parameter callInReverseOrder should be final. 56
Missing a Javadoc comment. 76
Missing a Javadoc comment. 77
Missing a Javadoc comment. 78
Line is longer than 80 characters. 80
Missing a Javadoc comment. 80
Parameter classLoader should be final. 80
'classLoader' hides a field. 80
Parameter children should be final. 80
'children' hides a field. 80
Line is longer than 80 characters. 85
Method 'invoke' is not designed for extension - needs to be abstract, final or empty. 85
Missing a Javadoc comment. 85
Parameter proxy should be final. 85
Parameter method should be final. 85
Parameter args should be final. 85
Line is longer than 80 characters. 89
Line is longer than 80 characters. 90
Line is longer than 80 characters. 91
Line is longer than 80 characters. 96
Line is longer than 80 characters. 97
Line is longer than 80 characters. 100
Line is longer than 80 characters. 104
Missing a Javadoc comment. 104
Parameter declaringClass should be final. 104
Parameter targets should be final. 104
Parameter method should be final. 104
Parameter args should be final. 104
Line is longer than 80 characters. 110
Line is longer than 80 characters. 136
Line is longer than 80 characters. 137
Avoid inline conditionals. 137
Parameter objects should be final. 148
Expected @param tag for 'objects'. 148
Line is longer than 80 characters. 153
Line is longer than 80 characters. 163

org/picocontainer/defaults/DefaultPicoContainer.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Unused import - java.util.Set. 28
Line is longer than 80 characters. 38
Missing a Javadoc comment. 40
Missing a Javadoc comment. 41
Line is longer than 80 characters. 43
Missing a Javadoc comment. 44
Variable 'unmanagedComponents' must be private and have accessor methods. 44
Missing a Javadoc comment. 46
Line is longer than 80 characters. 47
Missing a Javadoc comment. 47
Missing a Javadoc comment. 49
Missing a Javadoc comment. 50
Line is longer than 80 characters. 51
Missing a Javadoc comment. 55
Missing a Javadoc comment. 56
Parameter componentFactory should be final. 56
'componentFactory' hides a field. 56
Missing a Javadoc comment. 61
Missing a Javadoc comment. 62
Parameter componentRegistry should be final. 62
'componentRegistry' hides a field. 62
Line is longer than 80 characters. 67
Missing a Javadoc comment. 67
Parameter componentFactory should be final. 67
'componentFactory' hides a field. 67
Parameter componentRegistry should be final. 67
'componentRegistry' hides a field. 67
Missing a Javadoc comment. 79
Line is longer than 80 characters. 84
Missing a Javadoc comment. 84
Parameter callInInstantiationOrder should be final. 84
Parameter callUnmanagedComponents should be final. 84
Line is longer than 80 characters. 87
Line is longer than 80 characters. 98
Method 'registerComponent' is not designed for extension - needs to be abstract, final or empty. 98
Missing a Javadoc comment. 98
Parameter componentKey should be final. 98
Parameter componentImplementation should be final. 98
Redundant throws: 'DuplicateComponentKeyRegistrationException' is subclass of 'AssignabilityRegistrationException'. 98
Unable to get class information for DuplicateComponentKeyRegistrationException. 98
Redundant throws: 'AssignabilityRegistrationException' is subclass of 'NotConcreteRegistrationException'. 98
Unable to get class information for AssignabilityRegistrationException. 98
Redundant throws: 'NotConcreteRegistrationException' is subclass of 'PicoIntrospectionException'. 98
Unable to get class information for NotConcreteRegistrationException. 98
Unable to get class information for PicoIntrospectionException. 98
Line is longer than 80 characters. 103
Line is longer than 80 characters. 106
Method 'registerComponent' is not designed for extension - needs to be abstract, final or empty. 106
Missing a Javadoc comment. 106
Parameter componentKey should be final. 106
Parameter componentImplementation should be final. 106
Parameter parameters should be final. 106
Redundant throws: 'NotConcreteRegistrationException' is subclass of 'AssignabilityRegistrationException'. 106
Unable to get class information for NotConcreteRegistrationException. 106
Redundant throws: 'AssignabilityRegistrationException' is subclass of 'DuplicateComponentKeyRegistrationException'. 106
Unable to get class information for AssignabilityRegistrationException. 106
Unable to get class information for DuplicateComponentKeyRegistrationException. 106
Line is longer than 80 characters. 111
Missing a Javadoc comment. 114
Parameter compSpec should be final. 114
Line is longer than 80 characters. 118
Missing a Javadoc comment. 118
Parameter componentKey should be final. 118
Unable to get class information for DuplicateComponentKeyRegistrationException. 118
Line is longer than 80 characters. 119
Line is longer than 80 characters. 120
Line is longer than 80 characters. 127
Missing a Javadoc comment. 127
Parameter componentKey should be final. 127
Parameter componentImplementation should be final. 127
Unable to get class information for AssignabilityRegistrationException. 127
Line is longer than 80 characters. 131
Line is longer than 80 characters. 136
Missing a Javadoc comment. 136
Parameter componentImplementation should be final. 136
Unable to get class information for NotConcreteRegistrationException. 136
Line is longer than 80 characters. 138
Line is longer than 80 characters. 144
Method 'registerComponentByInstance' is not designed for extension - needs to be abstract, final or empty. 144
Missing a Javadoc comment. 144
Parameter component should be final. 144
Redundant throws: 'PicoRegistrationException' is subclass of 'PicoIntrospectionException'. 144
Unable to get class information for PicoRegistrationException. 144
Unable to get class information for PicoIntrospectionException. 144
Line is longer than 80 characters. 148
Method 'registerComponent' is not designed for extension - needs to be abstract, final or empty. 148
Missing a Javadoc comment. 148
Parameter componentKey should be final. 148
Parameter component should be final. 148
Redundant throws: 'PicoRegistrationException' is subclass of 'PicoIntrospectionException'. 148
Unable to get class information for PicoRegistrationException. 148
Unable to get class information for PicoIntrospectionException. 148
Line is longer than 80 characters. 151
Missing a Javadoc comment. 158
Line is longer than 80 characters. 162
Method 'addParameterToComponent' is not designed for extension - needs to be abstract, final or empty. 162
Missing a Javadoc comment. 162
Parameter componentKey should be final. 162
Parameter parameter should be final. 162
Parameter arg should be final. 162
Unable to get class information for PicoIntrospectionException. 162
Line is longer than 80 characters. 163
Line is longer than 80 characters. 167
Method 'registerComponentByClass' is not designed for extension - needs to be abstract, final or empty. 167
Missing a Javadoc comment. 167
Parameter componentImplementation should be final. 167
Redundant throws: 'DuplicateComponentKeyRegistrationException' is subclass of 'AssignabilityRegistrationException'. 167
Unable to get class information for DuplicateComponentKeyRegistrationException. 167
Redundant throws: 'AssignabilityRegistrationException' is subclass of 'NotConcreteRegistrationException'. 167
Unable to get class information for AssignabilityRegistrationException. 167
Redundant throws: 'NotConcreteRegistrationException' is subclass of 'PicoIntrospectionException'. 167
Unable to get class information for NotConcreteRegistrationException. 167
Unable to get class information for PicoIntrospectionException. 167
Line contains a tab character. 175
Method 'unregisterComponent' is not designed for extension - needs to be abstract, final or empty. 175
Parameter componentKey should be final. 175
Expected @param tag for 'componentKey'. 175
Line contains a tab character. 176
Line contains a tab character. 177
Line is longer than 80 characters. 179
Method 'instantiateComponents' is not designed for extension - needs to be abstract, final or empty. 179
Missing a Javadoc comment. 179
Redundant throws: 'PicoInitializationException' is subclass of 'PicoInvocationTargetInitializationException'. 179
Unable to get class information for PicoInitializationException. 179
Unable to get class information for PicoInvocationTargetInitializationException. 179
Expression can be simplified. 180
Missing a Javadoc comment. 189
Unable to get class information for PicoInitializationException. 189
Line is longer than 80 characters. 190
Line is longer than 80 characters. 191
Method 'getComponent' is not designed for extension - needs to be abstract, final or empty. 196
Missing a Javadoc comment. 196
Parameter componentKey should be final. 196
Method 'getComponents' is not designed for extension - needs to be abstract, final or empty. 200
Missing a Javadoc comment. 200
Comment matches to-do format 'TODO:'. 202
Line is longer than 80 characters. 212
Line is longer than 80 characters. 215
Line is longer than 80 characters. 216
Line is longer than 80 characters. 217
Line is longer than 80 characters. 220
Line is longer than 80 characters. 221
Line is longer than 80 characters. 222
Line is longer than 80 characters. 227
Method 'getComponentKeys' is not designed for extension - needs to be abstract, final or empty. 238
Missing a Javadoc comment. 238
Missing a Javadoc comment. 242
Parameter componentKey should be final. 242

org/picocontainer/defaults/DuplicateComponentKeyRegistrationException.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Line is longer than 80 characters. 15
Missing a Javadoc comment. 15
Missing a Javadoc comment. 16
Missing a Javadoc comment. 18
Parameter key should be final. 18
'key' hides a field. 18
Method 'getDuplicateKey' is not designed for extension - needs to be abstract, final or empty. 22
Missing a Javadoc comment. 22
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. 26
Missing a Javadoc comment. 26

org/picocontainer/defaults/NoPicoSuitableConstructorException.java

Error Line
Missing a header - not enough lines in file. 1
Line is longer than 80 characters. 15
Missing a Javadoc comment. 15
Missing a Javadoc comment. 17
Missing a Javadoc comment. 19
Parameter forClass should be final. 19
'forClass' hides a field. 19
Method 'getForImplementationClass' is not designed for extension - needs to be abstract, final or empty. 23
Missing a Javadoc comment. 23

org/picocontainer/defaults/NotConcreteRegistrationException.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Line is longer than 80 characters. 20
Missing a Javadoc comment. 21
Missing a Javadoc comment. 23
Parameter componentImplementation should be final. 23
'componentImplementation' hides a field. 23
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. 27
Missing a Javadoc comment. 27
Line is longer than 80 characters. 28
Method 'getComponentImplementation' is not designed for extension - needs to be abstract, final or empty. 31
Missing a Javadoc comment. 31

org/picocontainer/defaults/PicoInvocationTargetInitializationException.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Line is longer than 80 characters. 15
Missing a Javadoc comment. 15
Missing a Javadoc comment. 16
Missing a Javadoc comment. 18
Parameter cause should be final. 18
'cause' hides a field. 18
Method 'getCause' is not designed for extension - needs to be abstract, final or empty. 25
Missing a Javadoc comment. 25
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. 29
Missing a Javadoc comment. 29

org/picocontainer/defaults/UnsatisfiedDependencyInstantiationException.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Line is longer than 80 characters. 15
Missing a Javadoc comment. 15
Missing a Javadoc comment. 16
Missing a Javadoc comment. 17
Missing a Javadoc comment. 18
Line is longer than 80 characters. 20
Missing a Javadoc comment. 20
Parameter classThatNeeds should be final. 20
Parameter componentKey should be final. 20
'componentKey' hides a field. 20
Parameter neededDep should be final. 20
'neededDep' hides a field. 20
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. 26
Missing a Javadoc comment. 26
'+' should be on a new line. 27
Avoid inline conditionals. 28
Method 'getClassThatNeedsDeps' is not designed for extension - needs to be abstract, final or empty. 31
Missing a Javadoc comment. 31

org/picocontainer/extras/CompositePicoContainer.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Missing a Javadoc comment. 39
Missing a Javadoc comment. 40
Missing a Javadoc comment. 42
'componentRegistry' hides a field. 42
'containers' hides a field. 43
Line is longer than 80 characters. 52
Missing a Javadoc comment. 58
Missing a Javadoc comment. 59
'containers' hides a field. 59
Missing a Javadoc comment. 64
Missing a Javadoc comment. 65
Line is longer than 80 characters. 66
Method 'getComponent' is not designed for extension - needs to be abstract, final or empty. 70
Missing a Javadoc comment. 70
Parameter componentKey should be final. 70
Method 'getComponentKeys' is not designed for extension - needs to be abstract, final or empty. 83
Missing a Javadoc comment. 83
Method 'instantiateComponents' is not designed for extension - needs to be abstract, final or empty. 93
Missing a Javadoc comment. 93
Method 'hasComponent' is not designed for extension - needs to be abstract, final or empty. 97
Missing a Javadoc comment. 97
Parameter componentKey should be final. 97
Method 'getComponents' is not designed for extension - needs to be abstract, final or empty. 111
Missing a Javadoc comment. 111
Line is longer than 80 characters. 119
Method 'getComponentMulticaster' is not designed for extension - needs to be abstract, final or empty. 126
Missing a Javadoc comment. 126
Line is longer than 80 characters. 130
Method 'getComponentMulticaster' is not designed for extension - needs to be abstract, final or empty. 130
Missing a Javadoc comment. 130
Parameter callInInstantiationOrder should be final. 130
Parameter callUnmanagedComponents should be final. 130
Method 'addContainer' is not designed for extension - needs to be abstract, final or empty. 138
Parameter container should be final. 138
Expected @param tag for 'container'. 138
Method 'removeContainer' is not designed for extension - needs to be abstract, final or empty. 146
Parameter container should be final. 146
Expected @param tag for 'container'. 146

org/picocontainer/extras/CompositeProxyFactory.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 21

org/picocontainer/extras/DefaultLifecyclePicoAdaptor.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Missing a Javadoc comment. 19
Missing a Javadoc comment. 21
Missing a Javadoc comment. 22
Missing a Javadoc comment. 23
Missing a Javadoc comment. 24
Missing a Javadoc comment. 25
Missing a Javadoc comment. 26
Missing a Javadoc comment. 28
Parameter picoContainer should be final. 28
'picoContainer' hides a field. 28
Method 'isStarted' is not designed for extension - needs to be abstract, final or empty. 32
Missing a Javadoc comment. 32
Method 'isStopped' is not designed for extension - needs to be abstract, final or empty. 36
Missing a Javadoc comment. 36
Method 'isDisposed' is not designed for extension - needs to be abstract, final or empty. 40
Missing a Javadoc comment. 40
Missing a Javadoc comment. 44
Line is longer than 80 characters. 47
Must have at least one statement. 48
Line is longer than 80 characters. 54
Must have at least one statement. 55
Must have at least one statement. 63
Method 'start' is not designed for extension - needs to be abstract, final or empty. 69
Missing a Javadoc comment. 69
Method 'stop' is not designed for extension - needs to be abstract, final or empty. 81
Missing a Javadoc comment. 81
Expression can be simplified. 84
Method 'dispose' is not designed for extension - needs to be abstract, final or empty. 93
Missing a Javadoc comment. 93
Missing a Javadoc comment. 102

org/picocontainer/extras/HierarchicalComponentRegistry.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Line is longer than 80 characters. 27
Missing a Javadoc comment. 27
Missing a Javadoc comment. 29
Variable 'parentRegistry' must be private and have accessor methods. 29
Missing a Javadoc comment. 30
Variable 'childRegistry' must be private and have accessor methods. 30
Line is longer than 80 characters. 32
Missing a Javadoc comment. 32
Parameter parentRegistry should be final. 32
'parentRegistry' hides a field. 32
Parameter childRegistry should be final. 32
'childRegistry' hides a field. 32
Missing a Javadoc comment. 43
Missing a Javadoc comment. 44
Parameter parentRegistry should be final. 44
'parentRegistry' hides a field. 44
Line is longer than 80 characters. 49
Missing a Javadoc comment. 49
Line is longer than 80 characters. 50
Missing a Javadoc comment. 50
Parameter parentRegistry should be final. 50
'parentRegistry' hides a field. 50
Parameter childRegistry should be final. 50
'childRegistry' hides a field. 50
Method 'registerComponent' is not designed for extension - needs to be abstract, final or empty. 55
Missing a Javadoc comment. 55
Parameter compSpec should be final. 55
Line has trailing spaces. 58
Line contains a tab character. 59
Method 'unregisterComponent' is not designed for extension - needs to be abstract, final or empty. 59
Missing a Javadoc comment. 59
Parameter componentKey should be final. 59
Line contains a tab character. 60
Line contains a tab character. 61
Method 'getComponentSpecifications' is not designed for extension - needs to be abstract, final or empty. 63
Missing a Javadoc comment. 63
Method 'getOrderedComponents' is not designed for extension - needs to be abstract, final or empty. 67
Missing a Javadoc comment. 67
Method 'addOrderedComponent' is not designed for extension - needs to be abstract, final or empty. 77
Missing a Javadoc comment. 77
Parameter component should be final. 77
Method 'putComponent' is not designed for extension - needs to be abstract, final or empty. 81
Missing a Javadoc comment. 81
Parameter componentKey should be final. 81
Parameter component should be final. 81
Method 'contains' is not designed for extension - needs to be abstract, final or empty. 85
Missing a Javadoc comment. 85
Parameter componentKey should be final. 85
Method 'getComponentInstance' is not designed for extension - needs to be abstract, final or empty. 89
Missing a Javadoc comment. 89
Parameter componentKey should be final. 89
Method 'getComponentInstanceKeys' is not designed for extension - needs to be abstract, final or empty. 101
Missing a Javadoc comment. 101
Method 'getComponentInstances' is not designed for extension - needs to be abstract, final or empty. 113
Missing a Javadoc comment. 113
Method 'hasComponentInstance' is not designed for extension - needs to be abstract, final or empty. 123
Missing a Javadoc comment. 123
Parameter componentKey should be final. 123
Method 'getComponentSpec' is not designed for extension - needs to be abstract, final or empty. 128
Missing a Javadoc comment. 128
Parameter componentKey should be final. 128
Line is longer than 80 characters. 130
Line is longer than 80 characters. 140
Method 'findImplementingComponent' is not designed for extension - needs to be abstract, final or empty. 140
Missing a Javadoc comment. 140
Parameter componentType should be final. 140
Unable to get class information for AmbiguousComponentResolutionException. 140
Line is longer than 80 characters. 153
Method 'findImplementingComponentSpecification' is not designed for extension - needs to be abstract, final or empty. 153
Missing a Javadoc comment. 153
Parameter componentType should be final. 153
Unable to get class information for AmbiguousComponentResolutionException. 153
Line is longer than 80 characters. 156
Line is longer than 80 characters. 160
Line is longer than 80 characters. 165
Method 'createComponent' is not designed for extension - needs to be abstract, final or empty. 165
Missing a Javadoc comment. 165
Parameter componentSpecification should be final. 165
Unable to get class information for PicoInitializationException. 165
Line is longer than 80 characters. 167
Line is longer than 80 characters. 174

org/picocontainer/extras/ImplementationHidingComponentFactory.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Missing a Javadoc comment. 22
Missing a Javadoc comment. 23
Line is longer than 80 characters. 25
Missing a Javadoc comment. 25
Parameter componentFactory should be final. 25
'componentFactory' hides a field. 25
Line is longer than 80 characters. 29
Method 'createComponent' is not designed for extension - needs to be abstract, final or empty. 29
Missing a Javadoc comment. 29
Parameter componentSpec should be final. 29
Parameter instanceDependencies should be final. 29
Unable to get class information for PicoInitializationException. 29
Line is longer than 80 characters. 30
Line is longer than 80 characters. 33
Comment matches to-do format 'TODO:'. 35
Line is longer than 80 characters. 36
Line is longer than 80 characters. 37
Line is longer than 80 characters. 41
Method 'getDependencies' is not designed for extension - needs to be abstract, final or empty. 41
Missing a Javadoc comment. 41
Parameter componentImplementation should be final. 41
Unable to get class information for PicoIntrospectionException. 41
Missing a Javadoc comment. 45
Missing a Javadoc comment. 46
Missing a Javadoc comment. 48
Parameter componentInstance should be final. 48
'componentInstance' hides a field. 48
Line is longer than 80 characters. 52
Method 'invoke' is not designed for extension - needs to be abstract, final or empty. 52
Missing a Javadoc comment. 52
Parameter proxy should be final. 52
Parameter method should be final. 52
Parameter args should be final. 52

org/picocontainer/extras/NullContainer.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Unused import - java.util.Set. 16
Missing a Javadoc comment. 21
Method 'hasComponent' is not designed for extension - needs to be abstract, final or empty. 22
Missing a Javadoc comment. 22
Parameter compType should be final. 22
Method 'getComponent' is not designed for extension - needs to be abstract, final or empty. 26
Missing a Javadoc comment. 26
Parameter compType should be final. 26
Method 'getComponents' is not designed for extension - needs to be abstract, final or empty. 30
Missing a Javadoc comment. 30
Method 'getComponentKeys' is not designed for extension - needs to be abstract, final or empty. 34
Missing a Javadoc comment. 34
Missing a Javadoc comment. 38
Unable to get class information for PicoInstantiationException. 38
Method 'getComponentMulticaster' is not designed for extension - needs to be abstract, final or empty. 41
Missing a Javadoc comment. 41
Line is longer than 80 characters. 45
Method 'getComponentMulticaster' is not designed for extension - needs to be abstract, final or empty. 45
Missing a Javadoc comment. 45
Parameter callInInstantiationOrder should be final. 45
Parameter callUnmanagedComponents should be final. 45

org/picocontainer/internals/ComponentFactory.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Redundant import from the same package - org.picocontainer.internals.ComponentSpecification. 13
Missing a Javadoc comment. 17
Line is longer than 80 characters. 23
Expected an @return tag. 27
Line is longer than 80 characters. 27
Expected @param tag for 'componentSpec'. 27
Expected @throws tag for 'PicoInitializationException'. 27
Redundant throws: 'PicoInitializationException' is subclass of 'PicoIntrospectionException'. 27
Unable to get class information for PicoInitializationException. 27
Expected @throws tag for 'PicoIntrospectionException'. 27
Unable to get class information for PicoIntrospectionException. 27
Expected an @return tag. 34
Line is longer than 80 characters. 34
Expected @throws tag for 'PicoIntrospectionException'. 34
Unable to get class information for PicoIntrospectionException. 34

org/picocontainer/internals/ComponentParameter.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Unused import - org.picocontainer.PicoContainer. 3
Redundant import from the same package - org.picocontainer.internals.Parameter. 6
Redundant import from the same package - org.picocontainer.internals.ComponentRegistry. 7
Redundant import from the same package - org.picocontainer.internals.ComponentSpecification. 8
Missing a Javadoc comment. 18
Missing a Javadoc comment. 20
Missing a Javadoc comment. 23
Parameter componentKey should be final. 23
'componentKey' hides a field. 23
Line is longer than 80 characters. 27
Method 'resolve' is not designed for extension - needs to be abstract, final or empty. 27
Missing a Javadoc comment. 27
Parameter componentRegistry should be final. 27
Parameter compSpec should be final. 27
Parameter requestedType should be final. 27
Unable to get class information for PicoInitializationException. 28
Line is longer than 80 characters. 36
Line is longer than 80 characters. 40
Line is longer than 80 characters. 46
Line is longer than 80 characters. 50
Line is longer than 80 characters. 51
Line is longer than 80 characters. 55
Line is longer than 80 characters. 56
Line is longer than 80 characters. 64
Line is longer than 80 characters. 68

org/picocontainer/internals/ComponentRegistry.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Redundant import from the same package - org.picocontainer.internals.ComponentSpecification. 13
Missing a Javadoc comment. 21
Missing a Javadoc comment. 23
Missing a Javadoc comment. 25
Missing a Javadoc comment. 27
Missing a Javadoc comment. 29
Missing a Javadoc comment. 31
Missing a Javadoc comment. 33
Missing a Javadoc comment. 37
Missing a Javadoc comment. 39
Missing a Javadoc comment. 41
Missing a Javadoc comment. 43
Missing a Javadoc comment. 45
Line is longer than 80 characters. 47
Missing a Javadoc comment. 47
Unable to get class information for AmbiguousComponentResolutionException. 47
Line is longer than 80 characters. 49
Missing a Javadoc comment. 49
Unable to get class information for AmbiguousComponentResolutionException. 49
Line is longer than 80 characters. 51
Missing a Javadoc comment. 51
Unable to get class information for PicoInitializationException. 51
Line contains a tab character. 53
Missing a Javadoc comment. 53

org/picocontainer/internals/ComponentSpecification.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Missing a Javadoc comment. 19
Missing a Javadoc comment. 21
Missing a Javadoc comment. 22
Missing a Javadoc comment. 23
Missing a Javadoc comment. 24
Line is longer than 80 characters. 26
Missing a Javadoc comment. 26
Parameter componentFactory should be final. 26
'componentFactory' hides a field. 26
'componentKey' hides a field. 26
Parameter parameters should be final. 26
'parameters' hides a field. 26
Line is longer than 80 characters. 33
Missing a Javadoc comment. 33
Parameter componentFactory should be final. 33
'componentFactory' hides a field. 33
Parameter componentKey should be final. 33
'componentKey' hides a field. 33
Parameter comp should be final. 33
Unable to get class information for PicoIntrospectionException. 33
Line is longer than 80 characters. 38
Method 'createDefaultParameter' is not designed for extension - needs to be abstract, final or empty. 44
Missing a Javadoc comment. 44
Method 'getComponentKey' is not designed for extension - needs to be abstract, final or empty. 48
Missing a Javadoc comment. 48
Method 'getComponentImplementation' is not designed for extension - needs to be abstract, final or empty. 52
Missing a Javadoc comment. 52
Method 'instantiateComponent' is not designed for extension - needs to be abstract, final or empty. 56
Missing a Javadoc comment. 56
Parameter componentRegistry should be final. 56
Unable to get class information for PicoInitializationException. 57
Line is longer than 80 characters. 58
Line is longer than 80 characters. 61
Missing a Javadoc comment. 66
Parameter actual should be final. 66
Parameter requested should be final. 66
Line is longer than 80 characters. 71
Line is longer than 80 characters. 76
Method 'addConstantParameterBasedOnType' is not designed for extension - needs to be abstract, final or empty. 76
Missing a Javadoc comment. 76
Parameter parameter should be final. 76
Parameter arg should be final. 76
Unable to get class information for PicoIntrospectionException. 76
Line is longer than 80 characters. 78
Line is longer than 80 characters. 81
Line is longer than 80 characters. 87
Method 'getParameters' is not designed for extension - needs to be abstract, final or empty. 90
Missing a Javadoc comment. 90
Line has trailing spaces. 93
Line contains a tab character. 94
Definition of 'equals()' without corresponding definition of 'hashCode()'. 94
Method 'equals' is not designed for extension - needs to be abstract, final or empty. 94
Missing a Javadoc comment. 94
Parameter object should be final. 94
Line contains a tab character. 95
Line contains a tab character. 96
Line contains a tab character. 97
Line contains a tab character. 98
Line has trailing spaces. 99
Line contains a tab character. 99
Line contains a tab character. 100
'&&' should be on a new line. 100
Line is longer than 80 characters. 101
Line contains a tab character. 101
'&&' should be on a new line. 101
Line is longer than 80 characters. 102
Line contains a tab character. 102
Line contains a tab character. 103

org/picocontainer/internals/ConstantParameter.java

Error Line
Line does not match expected header line of 'Copyright (c) 2003, PicoContainer Organization'. 1
Missing a Javadoc comment. 20
Missing a Javadoc comment. 22
Parameter parameter should be final. 22
Line is longer than 80 characters. 26
Method 'resolve' is not designed for extension - needs to be abstract, final or empty. 26
Missing a Javadoc comment. 26
Parameter componentRegistry should be final. 26
Parameter compSpec should be final. 26
Parameter targetType should be final. 26
Unable to get class information for PicoInstantiationException. 26

org/picocontainer/internals/Parameter.java

Error Line
Missing a header - not enough lines in file. 1
Line is longer than 80 characters. 20
Missing a Javadoc comment. 20
Unable to get class information for PicoInitializationException. 21

org/picocontainer/lifecycle/Disposable.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 13
Missing a Javadoc comment. 14

org/picocontainer/lifecycle/Lifecycle.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 13

org/picocontainer/lifecycle/LifecyclePicoAdaptor.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 13
Missing a Javadoc comment. 15
Missing a Javadoc comment. 17
Missing a Javadoc comment. 19

org/picocontainer/lifecycle/Startable.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 14
Missing a Javadoc comment. 15

org/picocontainer/lifecycle/Stoppable.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 13
Missing a Javadoc comment. 14